Skip to content

Changeling Biodegrade#43671

Open
ScarKy0 wants to merge 8 commits intospace-wizards:masterfrom
ScarKy0:changeling-biodegrade
Open

Changeling Biodegrade#43671
ScarKy0 wants to merge 8 commits intospace-wizards:masterfrom
ScarKy0:changeling-biodegrade

Conversation

@ScarKy0
Copy link
Copy Markdown
Contributor

@ScarKy0 ScarKy0 commented Apr 20, 2026 •
edited
Loading

About the PR

Added the biodegrade ability for the changeling.

Why / Balance

Working towards #39439

Technical details

New actions that raises an event on itself and frees its owner. Long live standalone actions.
We get all cuffs and snares on an entity, then grab the first one from the list and show it as a popup.
Then uncuff, remove snares and delete all of them cause acid.

Media

image
2026-04-20.22-34-04.mp4

Requirements

Breaking changes

SharedCuffableSystem.IsCuffed() now takes Entity<CuffableComponent?> instead of Entity<CuffableComponent>
SharedEnsnareableSystem.ForceFree() now takes Entity<EnsnaringComponent?> instead of EntityUid, EnsnaringComponent?
EnsnareableComponent and EnsnaringComponent are now access restricted to SharedEnsnareableSystem

Changelog

  • add: Changeling is released! Rejoice!

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/M Denotes a PR that changes 100-999 lines. labels Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026 •
edited
Loading

RSI Diff Bot; head commit 58153a6 merging into f0de8dd
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Actions/changeling.rsi

State Old New Status
background Added
frame Added

Resources/Textures/Interface/Actions/changeling2.rsi

State Old New Status
biodegrade Added

Edit: diff updated after 58153a6

ScarKy0
ScarKy0 commented Apr 20, 2026
View reviewed changes
Comment thread Content.Shared/Changeling/Systems/ChangelingAbilitySystem.cs
Comment on lines +54 to +56
// How can you be ensnared/cuffed and have nothing detected??
if (toDelete.Count == 0)
return;
Copy link
Copy Markdown
Contributor Author

@ScarKy0 ScarKy0 Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory impossible but client crashes without it. Checking for ApplyingState doesn't help.
Complains that the list is empty, so probably something with snares or cuffs being not predicted/networked correctly?
Everything else works fine.

@ScarKy0 ScarKy0 mentioned this pull request Apr 20, 2026
Open
46 tasks
@ScarKy0 ScarKy0 requested a review from slarticodefast April 20, 2026 23:53
Golubgik
Golubgik reviewed Apr 21, 2026
View reviewed changes
Comment thread Content.Shared/Changeling/Components/ChangelingBiodegradeAbilityComponent.cs
@Pok27 Pok27 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slarticodefast slarticodefast Awaiting requested review from slarticodefast

1 more reviewer

@Golubgik Golubgik Golubgik left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ScarKy0 @Golubgik @PJBot @Pok27